fix(develop-docs): Restore old header and fix sidebar collapse on sub-pages#16641
Merged
stephanie-anderson merged 8 commits intomasterfrom Mar 2, 2026
Merged
Conversation
…-pages The nav refresh (fb3c1e1) added the new top navigation header unconditionally to all doc pages, including developer docs which should use the simpler original header. This also broke the sidebar on developer docs sub-pages because the collapsible section `isActive` check used exact path equality instead of prefix matching. - Add DevelopDocsHeader component with the original header layout - Conditionally render DevelopDocsHeader vs Header based on isDeveloperDocs - Fix DynamicNav isActive to use startsWith so child pages expand their parent section Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…xternal links The MobileMenu component hardcodes mainSections from navigationData.ts which contains user-facing doc links (/platforms/, /product/, etc.) that don't exist on the developer docs site. Replace with an inline popover menu that only shows the same external links as the desktop nav (Changelog, Sandbox, Go to Sentry, Get Started). Co-Authored-By: Claude <noreply@anthropic.com>
The sidebar is always visible at 768px+ (md) but the hamburger and mobile menu used lg-xl:hidden (1130px), leaving them visible but non-functional between 768-1130px. Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
…sibility - Change mobile menu from md:hidden to lg-xl:hidden so nav links are accessible between 768-1130px (where desktop nav is still hidden) - Fix aria-label from hardcoded "Close" to "Toggle sidebar navigation" - Remove aria-hidden="true" from label so button has an accessible name Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nav refresh (fb3c1e1) added the new top navigation header unconditionally
to all doc pages, including developer docs which should use the simpler original
header. This also broke the sidebar on developer docs sub-pages because the
collapsible section
isActivecheck used exact path equality instead ofprefix matching.
Co-Authored-By: Claude noreply@anthropic.com