Conversation
make the links in user 404s reports clickable for easy verifiability
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
Bundle ReportChanges will decrease total bundle size by 299 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
|
Related: seems like the 404 linter has failed to detect some of the 404s lately, maybe we need to re-visit |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Regex character class accidentally excludes literal dot
- Updated urlLineRegex to remove the unintended literal dot exclusion so dot-prefixed relative paths are now matched and linkified.
Or push these changes by commenting:
@cursor push 410b793782
Preview (410b793782)
diff --git a/.github/workflows/linkify-404s.yml b/.github/workflows/linkify-404s.yml
--- a/.github/workflows/linkify-404s.yml
+++ b/.github/workflows/linkify-404s.yml
@@ -23,7 +23,7 @@
// Find the FIRST url after in the "### URL" section produced by the form, replace it with a linkified version
// ignores the [url](url) pattern (set by the user or from a previous run)
- const urlLineRegex = /### URL\n+([^\[.\n].*)/;
+ const urlLineRegex = /### URL\n+([^\[\n].*)/;
const updated = body.replace(urlLineRegex, "### URL\n[$1]($1)")
if (updated !== body) {|
|
||
| // Find the FIRST url after in the "### URL" section produced by the form, replace it with a linkified version | ||
| // ignores the [url](url) pattern (set by the user or from a previous run) | ||
| const urlLineRegex = /### URL\n+([^\[.\n].*)/; |
There was a problem hiding this comment.
Regex character class accidentally excludes literal dot
Low Severity
The character class [^\[.\n] in urlLineRegex excludes literal . (dot is literal inside [...]), but the comment only explains the [ exclusion for avoiding already-linkified [url](url) patterns. The . exclusion is likely unintentional and would prevent matching any URL or path starting with a dot (e.g., ./relative/path). The intended character class was probably [^\[\n].
|
@a-hariti let me know if you can update this based on the bugbot feedback. one thing that would actually be really helpful is having the ticket report the previous page from where the 404 was accessed, not sure if we can do location.history or something and pass it off to the github issue |
3 participants
Motivation
make the links in user 404 reports clickable for easy verifiability
Not sure the ideal way to test this action aside from merging into master then observing its behavior