ref(build): Release Docker image to GHCR via Craft #5509
Conversation
Uses Craft's new version
brain getting to much work
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
aldy505
changed the title
aldy505
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| source: ghcr.io/getsentry/relay | ||
| target: ghcr.io/getsentry/relay | ||
| targetFormat: "{{{target}}}:latest" | ||
| - id: latest |
There was a problem hiding this comment.
Is that fine, having the same id twice?
There was a problem hiding this comment.
good question. @BYK do you have the answer?
There was a problem hiding this comment.
Quite sure you should not repeat an id.
| targetFormat: "{{{target}}}:latest" | ||
| - id: latest | ||
| name: docker | ||
| source: ghcr.io/getsentry/relay |
There was a problem hiding this comment.
Duplicate id: latest in Docker target configuration
Medium Severity
Two Docker target entries both use id: latest (one for GHCR at line 36 and one for DockerHub at line 45). As noted in the PR discussion by @BYK, repeating an id is not allowed in Craft configuration. This could cause one target to be ignored or overwritten, potentially resulting in only one of the "latest" Docker images being published during releases. The second entry needs a unique ID like latest-dockerhub.
🔬 Verification Test
Why verification test was not possible: This is a configuration file for Craft (a release automation tool), which requires the actual Craft tooling and release infrastructure to verify behavior. The issue is clearly documented in the PR discussion where maintainer @BYK confirmed "Quite sure you should not repeat an id." The duplicate can be verified by simple visual inspection of the YAML file showing two entries with id: latest at lines 36 and 41.
Additional Locations (1)
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
3 participants
This is an ongoing effort to simplify the release process to not rely on the hacky GitHub Actions script that copies the Docker image after a release was created.
Part of getsentry/self-hosted#4123
REF SELF-78
#skip-changelog