fix(attachments): Serialize ID without hyphens #5501
Merged
+68
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
changed the title
jjbayer
commented
Dec 19, 2025
| } | ||
|
|
||
| #[derive(Clone, Default, PartialEq, Empty, FromValue, ProcessValue)] | ||
| pub struct AttachmentId(Uuid); |
Member
Author
There was a problem hiding this comment.
This was largely copied from TraceId.
| return { | ||
| "trace_id": uuid.uuid4().hex, | ||
| "attachment_id": str(uuid.uuid4()), | ||
| "attachment_id": uuid.uuid4().hex, |
Member
Author
There was a problem hiding this comment.
The input doesn't need to be hyphen-free, but it makes comparisons with the output easier.
| pytest.param( | ||
| {"meta_length": None}, | ||
| 273, | ||
| 269, |
Member
Author
There was a problem hiding this comment.
No more hyphens -> saved some chars.
| def create_attachment_envelope(project_config): | ||
| return Envelope( | ||
| headers={ | ||
| "event_id": "515539018c9b4260a6f999572f1661ee", |
Member
Author
There was a problem hiding this comment.
Drive-by fix: trace attachment envelopes should not have an event ID.
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Comment on lines
336
to
342
| let key = Uuid::from_slice(&trace_item.trace_item.item_id) | ||
| .map_err(Error::from) | ||
| .reject(&trace_item)? | ||
| .as_simple() | ||
| .to_string(); | ||
|
|
||
| #[cfg(debug_assertions)] |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
tobias-wilfert
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialize attachment IDs without hyphens. This is the Sentry way, and aligns better with Event IDs and Trace IDs.
This also means that objectstore keys are now hyphen-free, which would be a breaking change if this wasn't an experimental feature.