Update example game playthrough with OpenSpiel of a Gambit extensive form game#787
Merged
edwardchalstrey1 merged 1 commit intomasterfrom Feb 26, 2026
Merged
Update example game playthrough with OpenSpiel of a Gambit extensive form game#787edwardchalstrey1 merged 1 commit intomasterfrom
edwardchalstrey1 merged 1 commit intomasterfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes in this PR
This PR updates the end of the OpenSpiel tutorial notebook to clarify playing through an extensive form game generated with Gambit - it was previously a bit confusing because OpenSpiel does not handle action labels in the same way as gambit:
When loading the one card poker example, which now has 2 different actions labeled "Fold" (one for each player), from Gambit, this actually confuses the OpenSpiel game in thinking there are fewer distinct actions than there are.
The updated code doesn't run
ops_one_card_poker.num_distinct_actions()- this difference may be of relevance we revisit OpenSpiel<=>Gambit importer/exporter code - I have made a note of this.How to review this PR
I'm going to merge this without review provided the notebook renders correctly.