[Repo Assist] Design parity with TaskSeq, batch 3 (#277)#282
Draft
github-actions[bot] wants to merge 2 commits intomainfrom
Draft
[Repo Assist] Design parity with TaskSeq, batch 3 (#277)#282github-actions[bot] wants to merge 2 commits intomainfrom
github-actions[bot] wants to merge 2 commits intomainfrom
Conversation
… unbox, cast, lengthOrMax (#277) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Continues the design-parity work from #277, adding the remaining functions identified in the original API gap analysis.
New functions
insertManyAtTaskSeq.insertManyAtremoveManyAtTaskSeq.removeManyAtboxobjTaskSeq.boxunbox<'T>objelement to'TTaskSeq.unboxcast<'T>objelement to'TTaskSeq.castlengthOrMaxTaskSeq.lengthOrMaxNote on
exceptOfSeq:AsyncSeq.exceptalready acceptsseq<'T>for the excluded collection, so no separateexceptOfSeqis needed — it was already covered.API gap: now closed
With this batch, all items from the original gap analysis in #277 are implemented. The full list of additions across batches 1–3:
withCancellationtryTail,where/whereAsync,lengthBy/lengthByAsync,compareWith/compareWithAsync,takeWhileInclusiveAsync,skipWhileInclusive/skipWhileInclusiveAsync,appendSeq/prependSeq,delay,collectAsync,partition/partitionAsyncinsertManyAt,removeManyAt,box,unbox,cast,lengthOrMaxChanges
src/FSharp.Control.AsyncSeq/AsyncSeq.fs— 6 new function implementationssrc/FSharp.Control.AsyncSeq/AsyncSeq.fsi— 9 new public signatures with XML-doctests/FSharp.Control.AsyncSeq.Tests/AsyncSeqTests.fs— 18 new testsRELEASE_NOTES.md— 4.11.0 entryversion.props— bumped to 4.11.0Test Status
✅ Build succeeded (0 errors, pre-existing warnings only — NU1605, FS9999 for
groupByAsync).✅ All 341 tests pass — 18 new, 323 pre-existing.
Related to We want design parity with FSharp.Control.TaskSeq #277
Fixes We want design parity with FSharp.Control.TaskSeq #277