Stepped rotation + node tangents snapping#650
Open
pgilfernandez wants to merge 3 commits intofriction2d:mainfrom
Open
Stepped rotation + node tangents snapping#650pgilfernandez wants to merge 3 commits intofriction2d:mainfrom
pgilfernandez wants to merge 3 commits intofriction2d:mainfrom
Conversation
Closed
Author
|
Well, I was able to add snapping to node tangents as well for both normal path nodes and keyframe bezier tangent nodes at the timeline Graph view mode... pretty cool and handy 😄 In the way I found a regression that I also fixed with #651 |
b3829f1 to
80d90fa
Compare
Author
|
Hi @rodlie, I've rebased this PR, it works fine in RC3 and adds this nice and requested feature, please, have a look at it and consider it to be included in final v1.0 😉 |
Member
Sure, will take a look this weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related with #250 and #628 (comment)
While rotating you can use
shiftmodifier for 15º snapping orctrl/cmdfor 1º snapping.It's indeed compatible with numerical input (it doesn't block it), rotating with
Rand gizmo.Note that it is a stepped rotation by 15 or 1 degrees starting with the original rotation value the object had, it is not a snapping rotation where the rotation snaps to "previously fixed canvas rotations" (0º, 15º, 30º, ...). BTW, it's the way Inkscape and other software does it.
Further implementation would be using variables instead, so the rotation steps are configurable via Preferences and make the modifier also configurable (this is more related with shortcuts configuration...), but I don't know if that part should wait for v1.1 as it needs to change that panel... let me know what do you think and we find the right place.
I'm going to investigate if this feature can be as easily be implemented for node tangents too...