fix(tests): use proper error return instead of panic for null checks #184
+27
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `.?` with `orelse return error.TestUnexpectedResult` in tests that validate parsing functions return non-null for valid inputs. This provides proper test failure messages instead of panics, and is more idiomatic Zig test code.
Replace `.?` force unwraps with `orelse return`/`orelse continue` patterns for texture rendering and optional field access. This makes the code more defensive and eliminates static analysis warnings about potentially unsafe unwraps. Changes: - Render functions now unwrap textures with orelse return early - Field access uses orelse continue in loops - font_cache uses getOrPut to avoid put-then-getPtr pattern - state.zig uses local variable instead of immediate unwrap after assignment
Reverts the defensive null check change since zwanzig now properly
recognizes the `if (x != null) { x.? }` pattern inside switch arms.
The original idiomatic Zig pattern is now correctly handled by the
linter without false positives.
Reverts the defensive null check change for the terminal access pattern
since zwanzig now properly recognizes `if (x != null) { x.? }` guards.
The line 310 case remains as defensive code since it relies on a labeled
block establishing an invariant that zwanzig can't track.
Zwanzig now handles the `self.method() catch return; ... self.field.?` pattern via interprocedural analysis, so defensive code is no longer needed.
Instead of having ensureTextures() set fields that are later unwrapped in separate render functions, pass the textures as explicit parameters. This makes the data flow clear and avoids fragile cross-function assumptions about field state. Also fix continue -> return false in session_interaction.zig where there was no enclosing loop.
Zwanzig now handles `self.field = try expr; self.field.?` pattern.
Revert the defensive `orelse return false` to the original `.?` unwrap. Zwanzig now correctly handles the labeled block invariant pattern where `should_forward` being true implies `session.terminal` is non-null.
Update zwanzig dependency from v0.3.0 to v0.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
.?withorelse return error.TestUnexpectedResultin tests that validate parsing functions return non-null for valid inputs.This provides proper test failure messages instead of panics, and is more idiomatic Zig test code.