fix: prevent malformed CRD resources from crashing the controller #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
adityathebe
force-pushed
the
feat/resilient-unstructured-reconciler
branch
from
35cb10c to
a9222bb
Compare
- Return error instead of nil when unstructured-to-typed conversion fails. This ensures malformed resources are requeued for retry rather than being silently dropped. - Remove unused tests/crdgen/ packages and generate.sh script. These types were only used for CRD generation but the test uses unstructured objects directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Unstructured objects in the cache instead of typed objects. This ensures cache synchronization succeeds even when some resources have specs that don't match the Go type definitions.