fix(NoTicket): update sqlparse to fix query splitting#489
Open
fix(NoTicket): update sqlparse to fix query splitting#489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sqlparse has a bug where it mistakenly splits a query at a semicolon that's actually inside a string literal: andialbrecht/sqlparse#839
Since there are many open sqlparse PRs, it doesn't seem reasonable to wait for upstream to merge the PR and release a new version. Instead, just switch to the fixed fork, and pin to an exact commit (lorenzhs/sqlparse@8d37938)