Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #1070 +/- ##
===========================================
- Coverage 94.90% 94.82% -0.09%
===========================================
Files 44 44
Lines 3102 3170 +68
===========================================
+ Hits 2944 3006 +62
- Misses 158 164 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
In order to propagate the change to the mixed domain class I need #1060 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Do not merge before #1060
Summary
Adds a default custom monitor to the SNES solver. It also adds a custom convergence test for more control.
Usage:
Simply set the log level to INFO/DEBUG
Related Issues
closing #1062
Motivation and Context
This gives users better understanding on the solver behaviour by logging norms and tolerances for the SNES iterations and KSP iterations
Type of Change
Testing
pytest)Code Quality Checklist
ruff format .)ruff check .)Documentation
Breaking Changes
Screenshots/Examples
Additional Notes