Add command and docs about test-examples#574
Conversation
Summary of ChangesHello @2chanhaeng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a robust testing framework for all example projects, ensuring their reliability and ease of use. It also includes critical fixes and minor enhancements across various examples and core integration packages, improving overall stability and developer experience. The changes streamline the development workflow by providing automated verification for examples and refining how host information is handled in web framework integrations. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a test runner for example projects and fixes several issues across the examples to ensure they work correctly. It also includes improvements to the Express and NestJS integrations. While the addition of the test runner is a great improvement for maintainability, there is a regression in how URLs are reconstructed in the Express and NestJS middlewares, which causes port numbers to be lost. Additionally, the new test runner script has some cross-platform compatibility issues on Windows that should be addressed.
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
dahlia
left a comment
There was a problem hiding this comment.
Could you resolve the conflict on pnpm-lock.yaml? It would be easily resolvable by running pnpm i.
Summary
Add test-examples and fix examples
Changes
examples/test-examples@fedify/express,@fedify/fastify.Benefits
No errors in examples and test all examples at once.
Improve
@fedify/expressand@fedify/fastify.Checklist
Did you add a changelog entry to the CHANGES.md?Did you write some tests for this change (if it's a new feature)?Did you runmise teston your machine?