π§± Mason: Decouple Q-Learning from HashMap storage (Fixes SRP/DIP) #447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ποΈ Violation: The
TabularQAgentclass mixed two responsibilities: managing the Q-Table storage (using aHashMap) and implementing the Q-Learning update algorithm. This violated the Single Responsibility Principle (SRP) and made it impossible to extend the agent to use other storage mechanisms (like arrays or function approximators) without modifying the core class (violating Open/Closed Principle).ποΈ Fix:
QFunctiontrait instorage.rsto define the interface for getting and setting Q-values.HashMapQFunctionas the default concrete implementation.TabularQAgentinto a genericQAgent<S, A, Q>that depends on theQFunctionabstraction.pub type TabularQAgent<S, A> = QAgent<S, A, HashMapQFunction<S, A>>;to ensure backward compatibility for existing code.π Principle:
HashMapQFunction, learning logic is inQAgent.QAgentdepends on theQFunctionabstraction, not the concreteHashMap.QFunctionwithout changingQAgent.π§ͺ Verification:
cargo test --test test_rlwhich passed.TabularQAgentusing the legacy constructor, confirming that the type alias and specializedimplblock work as expected.PR created automatically by Jules for task 8894124242979632810 started by @fderuiter