Skip to content

🏗️ Architect: Refactor ImednetSDK for Modularity#635

Draft
fderuiter wants to merge 1 commit intomainfrom
architect/refactor-sdk-10359927914354068148
Draft

🏗️ Architect: Refactor ImednetSDK for Modularity#635
fderuiter wants to merge 1 commit intomainfrom
architect/refactor-sdk-10359927914354068148

Conversation

@fderuiter
Copy link
Owner

🏗️ Design Change:

  • Extracted convenience methods from ImednetSDK to ImednetSDKConvenienceMixin in imednet/sdk_convenience.py.
  • Moved endpoint registry to imednet/endpoints/registry.py to decouple configuration.
  • Enforced strict return types (Dict[str, Any]) in Paginators.

♻️ DRY Gains:

  • Reduced imednet/sdk.py size significantly, adhering to Single Responsibility Principle.

🛡️ Solidity:

  • Improved type safety in pagination.
  • Reduced "God Class" complexity of ImednetSDK.

⚠️ Breaking Changes:

  • None to the public API. Users can still import ImednetSDK and use methods like get_studies exactly as before.

PR created automatically by Jules for task 10359927914354068148 started by @fderuiter

- Move `get_*` and `create_*` methods to `ImednetSDKConvenienceMixin`.
- Move `_ENDPOINT_REGISTRY` to `imednet/endpoints/registry.py`.
- Update `Paginator` to return `Dict[str, Any]` instead of `Any`.
- Clean up `imednet/sdk.py` imports.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant