Deal with total_concurrency and n weirdness: introduce ExperimentDesign.concurrency_limit
#4732
+1,450
−970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@lena-kashtelyan has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89770462. |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Dec 31, 2025
…tDesign.concurrency_limit` (facebook#4732) Summary: Pull Request resolved: facebook#4732 As titled, adding a simple `ExperimentDesign` object. Putting it into properties for serialization for now, so as to not do duplicate work ahead of the storage refactor implementation (and also in case we change things while working on this stack). Differential Revision: D89770462 Privacy Context Container: L1307644
lena-kashtelyan
force-pushed
the
export-D89770462
branch
from
89e2d62 to
5d39841
Compare
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Dec 31, 2025
…tDesign.concurrency_limit` (facebook#4732) Summary: As titled, adding a simple `ExperimentDesign` object. Putting it into properties for serialization for now, so as to not do duplicate work ahead of the storage refactor implementation (and also in case we change things while working on this stack). Differential Revision: D89770462 Privacy Context Container: L1307644
lena-kashtelyan
force-pushed
the
export-D89770462
branch
from
5d39841 to
09f3427
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4732 +/- ##
==========================================
- Coverage 96.72% 96.71% -0.01%
==========================================
Files 582 583 +1
Lines 60694 60729 +35
==========================================
+ Hits 58706 58737 +31
- Misses 1988 1992 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary: Pull Request resolved: facebook#4731 A lot going on here: 1. Make `GenerationStep` a factory for `GenerationNode` by replacing its `__init__(self, ...)` constructor (which would have to return a `GStep`) with a `__new__(cls, ...)` construtor, which can return a `GNode` (magic, thanks Devmate!) 2. Adapt storage: stop storing steps and just treat them as nodes. No step-only fields will be saved going forward. Backward compatibility is handled though. 3. Change a bazillion tests and checks in downstream applications. NOTE: need to remember next steps here: https://www.internalfb.com/diff/D86066476?dst_version_fbid=732904879835890&transaction_fbid=1400151778204976, cc mgarrard sorrybigdiff Differential Revision: D80128678 Privacy Context Container: L1307644 Reviewed By: mgarrard
…tDesign.concurrency_limit` (facebook#4732) Summary: Pull Request resolved: facebook#4732 As titled, adding a simple `ExperimentDesign` object. Putting it into properties for serialization for now, so as to not do duplicate work ahead of the storage refactor implementation (and also in case we change things while working on this stack). Differential Revision: D89770462 Privacy Context Container: L1307644
lena-kashtelyan
force-pushed
the
export-D89770462
branch
from
09f3427 to
68d37c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled, adding a simple
ExperimentDesignobject. Putting it into properties for serialization for now, so as to not do duplicate work ahead of the storage refactor implementation (and also in case we change things while working on this stack).Differential Revision:
D89770462
Privacy Context Container: L1307644