Skip to content

Conversation

@saitcakmak
Copy link
Contributor

Summary: Simplifies common checks for num initialization trials etc that we do for node based GS

Differential Revision:
D89932177

Privacy Context Container: L1307644

@meta-codesync
Copy link

meta-codesync bot commented Dec 30, 2025

@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89932177.

@meta-cla meta-cla bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 30, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2025

Codecov Report

❌ Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.71%. Comparing base (1afc5b8) to head (8c32f39).

Files with missing lines Patch % Lines
ax/utils/testing/modeling_stubs.py 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4729      +/-   ##
==========================================
- Coverage   96.72%   96.71%   -0.01%     
==========================================
  Files         582      582              
  Lines       60694    60702       +8     
==========================================
+ Hits        58706    58708       +2     
- Misses       1988     1994       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

saitcakmak added a commit to saitcakmak/Ax that referenced this pull request Dec 30, 2025
Summary:

Simplifies common checks for num initialization trials etc that we do for node based GS

Differential Revision:
D89932177

Privacy Context Container: L1307644
Summary:

Simplifies common checks for num initialization trials etc that we do for node based GS

Reviewed By: sdaulton

Differential Revision:
D89932177

Privacy Context Container: L1307644
@meta-codesync
Copy link

meta-codesync bot commented Jan 2, 2026

This pull request has been merged in 783f108.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants