Merge MapData into Data #4715

esantorella · 2025-12-26T19:55:21Z

Summary:
This diff merges MapData into Data by giving Data an attribute has_step_column. MapData becomes an empty subclass which will be removed in a subsequent diff.

Changes:

Functionality from map_data.py is moved into data.py

Differential Revision: D89820078

meta-codesync · 2025-12-26T19:55:28Z

@esantorella has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89820078.

Summary: This diff merges MapData into Data by giving Data an attribute `has_step_column`. MapData becomes an empty subclass which will be removed in a subsequent PR (D89814417). Changes: * Functionality from map_data.py is moved into data.py, and functionality from MapData moves into Data; MapData is an empty subclass. * Data (and MapData) get an attribute `has_step_column`; the important distinction becomes `has_step_column`, not type. * It is now possible for both `Data` and `MapData` to either have a step column or not. Having both `Data` and `MapData` like this is an unpleasant intermediate state that we should move off of immediately (landing this and D89814417 together) * Many `isinstance` checks become `has_step_coumn` checks * Data's new methods `subsample` and `latest` get special cases for when there is no "step" column * Make Data's required columns always be the same and not contain "step" (since it isn't really required). Remove `required_columns` method. Differential Revision: D89820078

codecov-commenter · 2025-12-26T22:47:58Z

Codecov Report

❌ Patch coverage is 96.82540% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.72%. Comparing base (2a45185) to head (51e6b96).

Files with missing lines	Patch %	Lines
ax/core/data.py	96.05%	3 Missing ⚠️
ax/service/utils/best_point_mixin.py	50.00%	2 Missing ⚠️
ax/early_stopping/experiment_replay.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4715   +/-   ##
=======================================
  Coverage   96.72%   96.72%           
=======================================
  Files         582      582           
  Lines       60744    60757   +13     
=======================================
+ Hits        58753    58770   +17     
+ Misses       1991     1987    -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Summary: Pull Request resolved: facebook#4715 This diff merges MapData into Data by giving Data an attribute `has_step_column`. MapData becomes an empty subclass which will be removed in a subsequent PR (D89814417). Changes: * Functionality from map_data.py is moved into data.py, and functionality from MapData moves into Data; MapData is an empty subclass. * Data (and MapData) get an attribute `has_step_column`; the important distinction becomes `has_step_column`, not type. * It is now possible for both `Data` and `MapData` to either have a step column or not. Having both `Data` and `MapData` like this is an unpleasant intermediate state that we should move off of immediately (landing this and D89814417 together) * Many `isinstance` checks become `has_step_coumn` checks * Data's new methods `subsample` and `latest` get special cases for when there is no "step" column * Make Data's required columns always be the same and not contain "step" (since it isn't really required). Remove `required_columns` method. Differential Revision: D89820078 Privacy Context Container: L1307644 Reviewed By: lena-kashtelyan

Summary: This diff merges MapData into Data by giving Data an attribute `has_step_column`. MapData becomes an empty subclass which will be removed in a subsequent PR (D89814417). Note on how this diff is split up: In this diff, functions that previously required MapData now can consume Data, and type checks stop referencing MapData. However, functions can still return MapData; all references are removed in the next diff. Changes: * Functionality from map_data.py is moved into data.py, and functionality from MapData moves into Data; MapData is an empty subclass. * Data (and MapData) get an attribute `has_step_column`; the important distinction becomes `has_step_column`, not type. * It is now possible for both `Data` and `MapData` to either have a step column or not. Having both `Data` and `MapData` like this is an unpleasant intermediate state that we should move off of immediately (landing this and D89814417 together) * Many `isinstance` checks become `has_step_coumn` checks * Data's new methods `subsample` and `latest` get special cases for when there is no "step" column * Make Data's required columns always be the same and not contain "step" (since it isn't really required). Remove `required_columns` method. Reviewed By: lena-kashtelyan Differential Revision: D89820078

Summary: Pull Request resolved: facebook#4715 This diff merges MapData into Data by giving Data an attribute `has_step_column`. MapData becomes an empty subclass which will be removed in a subsequent PR (D89814417). Note on how this diff is split up: In this diff, functions that previously required MapData now can consume Data, and type checks stop referencing MapData. However, functions can still return MapData; all references are removed in the next diff. Changes: * Functionality from map_data.py is moved into data.py, and functionality from MapData moves into Data; MapData is an empty subclass. * Data (and MapData) get an attribute `has_step_column`; the important distinction becomes `has_step_column`, not type. * It is now possible for both `Data` and `MapData` to either have a step column or not. Having both `Data` and `MapData` like this is an unpleasant intermediate state that we should move off of immediately (landing this and D89814417 together) * Many `isinstance` checks become `has_step_coumn` checks * Data's new methods `subsample` and `latest` get special cases for when there is no "step" column * Make Data's required columns always be the same and not contain "step" (since it isn't really required). Remove `required_columns` method. Differential Revision: D89820078 Privacy Context Container: L1307644 Reviewed By: lena-kashtelyan

Summary: Pull Request resolved: facebook#4715 This diff merges MapData into Data by giving Data an attribute `has_step_column`. MapData becomes an empty subclass which will be removed in a subsequent PR (D89814417). Note on how this diff is split up: In this diff, functions that previously required MapData now can consume Data, and type checks stop referencing MapData. However, functions can still return MapData; all references are removed in the next diff. Changes: * Functionality from map_data.py is moved into data.py, and functionality from MapData moves into Data; MapData is an empty subclass. * Data (and MapData) get an attribute `has_step_column`; the important distinction becomes `has_step_column`, not type. * It is now possible for both `Data` and `MapData` to either have a step column or not. Having both `Data` and `MapData` like this is an unpleasant intermediate state that we should move off of immediately (landing this and D89814417 together) * Many `isinstance` checks become `has_step_coumn` checks * Data's new methods `subsample` and `latest` get special cases for when there is no "step" column * Make Data's required columns always be the same and not contain "step" (since it isn't really required). Remove `required_columns` method. Reviewed By: saitcakmak, lena-kashtelyan Differential Revision: D89820078

Summary: This diff merges MapData into Data by giving Data an attribute `has_step_column`. MapData becomes an empty subclass which will be removed in a subsequent PR (D89814417). Note on how this diff is split up: In this diff, functions that previously required MapData now can consume Data, and type checks stop referencing MapData. However, functions can still return MapData; all references are removed in the next diff. Changes: * Functionality from map_data.py is moved into data.py, and functionality from MapData moves into Data; MapData is an empty subclass. * Data (and MapData) get an attribute `has_step_column`; the important distinction becomes `has_step_column`, not type. * It is now possible for both `Data` and `MapData` to either have a step column or not. Having both `Data` and `MapData` like this is an unpleasant intermediate state that we should move off of immediately (landing this and D89814417 together) * Many `isinstance` checks become `has_step_coumn` checks * Data's new methods `subsample` and `latest` get special cases for when there is no "step" column * Make Data's required columns always be the same and not contain "step" (since it isn't really required). Remove `required_columns` method. Reviewed By: saitcakmak, lena-kashtelyan Differential Revision: D89820078

Summary: Pull Request resolved: facebook#4715 This diff merges MapData into Data by giving Data an attribute `has_step_column`. MapData becomes an empty subclass which will be removed in a subsequent PR (D89814417). Note on how this diff is split up: In this diff, functions that previously required MapData now can consume Data, and type checks stop referencing MapData. However, functions can still return MapData; all references are removed in the next diff. Changes: * Functionality from map_data.py is moved into data.py, and functionality from MapData moves into Data; MapData is an empty subclass. * Data (and MapData) get an attribute `has_step_column`; the important distinction becomes `has_step_column`, not type. * It is now possible for both `Data` and `MapData` to either have a step column or not. Having both `Data` and `MapData` like this is an unpleasant intermediate state that we should move off of immediately (landing this and D89814417 together) * Many `isinstance` checks become `has_step_coumn` checks * Data's new methods `subsample` and `latest` get special cases for when there is no "step" column * Make Data's required columns always be the same and not contain "step" (since it isn't really required). Remove `required_columns` method. Differential Revision: D89820078 Privacy Context Container: L1307644 Reviewed By: saitcakmak, lena-kashtelyan

Summary: This diff merges MapData into Data by giving Data an attribute `has_step_column`. MapData becomes an empty subclass which will be removed in a subsequent PR (D89814417). Note on how this diff is split up: In this diff, functions that previously required MapData now can consume Data, and type checks stop referencing MapData. However, functions can still return MapData; all references are removed in the next diff. Changes: * Functionality from map_data.py is moved into data.py, and functionality from MapData moves into Data; MapData is an empty subclass. * Data (and MapData) get an attribute `has_step_column`; the important distinction becomes `has_step_column`, not type. * It is now possible for both `Data` and `MapData` to either have a step column or not. Having both `Data` and `MapData` like this is an unpleasant intermediate state that we should move off of immediately (landing this and D89814417 together) * Many `isinstance` checks become `has_step_coumn` checks * Data's new methods `subsample` and `latest` get special cases for when there is no "step" column * Make Data's required columns always be the same and not contain "step" (since it isn't really required). Remove `required_columns` method. Reviewed By: saitcakmak, lena-kashtelyan Differential Revision: D89820078

meta-codesync · 2026-01-02T19:42:05Z

This pull request has been merged in 2151d86.

meta-cla bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 26, 2025

meta-codesync bot added fb-exported meta-exported labels Dec 26, 2025

esantorella force-pushed the export-D89820078 branch 2 times, most recently from 955585d to 3adf3ac Compare December 26, 2025 22:15

esantorella force-pushed the export-D89820078 branch from 3adf3ac to a83ae73 Compare December 29, 2025 16:23

esantorella force-pushed the export-D89820078 branch from a83ae73 to 0ccd306 Compare December 29, 2025 16:41

esantorella force-pushed the export-D89820078 branch from 0ccd306 to 75ea48a Compare December 29, 2025 16:44

esantorella force-pushed the export-D89820078 branch 2 times, most recently from b7ef5c7 to 64200ce Compare January 2, 2026 15:21

esantorella force-pushed the export-D89820078 branch from 64200ce to 51e6b96 Compare January 2, 2026 17:42

meta-codesync bot closed this in 2151d86 Jan 2, 2026

facebook-github-bot added the Merged label Jan 2, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Merge MapData into Data #4715

Merge MapData into Data #4715

esantorella commented Dec 26, 2025

Uh oh!

meta-codesync bot commented Dec 26, 2025

Uh oh!

codecov-commenter commented Dec 26, 2025 •

edited

Loading

Uh oh!

meta-codesync bot commented Jan 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Merge MapData into Data #4715

Merge MapData into Data #4715

Conversation

esantorella commented Dec 26, 2025

Uh oh!

meta-codesync bot commented Dec 26, 2025

Uh oh!

codecov-commenter commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

meta-codesync bot commented Jan 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov-commenter commented Dec 26, 2025 •

edited

Loading