Refine DataLoaderConfig. statuses_to_fit to STATUSES_EXPECTING_DATA #4589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
This change updates `DataLoaderConfig.statuses_to_fit` to use `STATUSES_EXPECTING_DATA` plus `TrialStatus.CANDIDATE` instead of `NON_ABANDONED_STATUSES`. This is a semantic narrowing: instead of including all trial statuses except `ABANDONED` (which includes `CANDIDATE`, `STAGED`, `FAILED`, `STALE`, etc.), it now only includes trials that are expected to have reliable data (`RUNNING`, `COMPLETED`, `EARLY_STOPPED`) plus `CANDIDATE` explicitly.
**Changes:**
- Changes implementation from `NON_ABANDONED_STATUSES` to `{*STATUSES_EXPECTING_DATA, TrialStatus.CANDIDATE}`
- Updates docstrings in both `statuses_to_fit` and `statuses_to_fit_map_metric` to accurately reflect the new behavior, explicitly listing the statuses: `RUNNING`, `COMPLETED`, `EARLY_STOPPED`, plus `CANDIDATE`
Differential Revision: D83514647
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change updates
DataLoaderConfig.statuses_to_fitto useSTATUSES_EXPECTING_DATAplusTrialStatus.CANDIDATEinstead ofNON_ABANDONED_STATUSES. This is a semantic narrowing: instead of including all trial statuses exceptABANDONED(which includesCANDIDATE,STAGED,FAILED,STALE, etc.), it now only includes trials that are expected to have reliable data (RUNNING,COMPLETED,EARLY_STOPPED) plusCANDIDATEexplicitly.Changes:
NON_ABANDONED_STATUSESto{*STATUSES_EXPECTING_DATA, TrialStatus.CANDIDATE}statuses_to_fitandstatuses_to_fit_map_metricto accurately reflect the new behavior, explicitly listing the statuses:RUNNING,COMPLETED,EARLY_STOPPED, plusCANDIDATEDifferential Revision: D83514647