Skip to content

Fix dependency declaration in setup.py #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
calchiwo wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix dependency declaration in setup.py #98

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad8781b
Fix dependency declaration in setup.py
calchiwo Dec 24, 2025
dda05bf
Remove setup-time network and version logic
calchiwo Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 8 additions & 84 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,87 +1,9 @@
from setuptools import setup, find_packages
import subprocess
import codecs
import os

try:
import requests
requests_installed = True
except ImportError:
requests_installed = False
VERSION = "0.0.1"

#VERSION = '0.0.1'
# VERSION = (
# subprocess.run(["git", "describe", "--tags"], stdout=subprocess.PIPE)
# .stdout.decode("utf-8")
# .strip()
# )
DESCRIPTION = "A simple library for Python beginners"

def get_pypi_version():
if not requests_installed:
print("Warning: 'requests' module is not installed. Using default version.")
return "0.0.1"
try:
response = requests.get("https://pypi.org/pypi/easyPythonpi/json")
data = response.json()
return str(data["info"]["version"])
except Exception as e:
print(f"Error fetching version from PyPI: {e}")
return "0.0.1"

def increment_version(version):
major, minor, patch = map(int, version.split('.'))
patch += 1
if patch > 9:
patch = 0
minor += 1
if minor > 9:
minor = 0
major += 1
return f"{major}.{minor}.{patch}"

def get_version():
pypi_version = get_pypi_version()
new_version = increment_version(pypi_version)

try:
git_describe = subprocess.run(["git", "describe", "--tags"], stdout=subprocess.PIPE, stderr=subprocess.PIPE, check=True)
git_version = git_describe.stdout.decode("utf-8").strip()

if "-" in git_version:
v, i, s = git_version.split("-")
git_version = f"{new_version}+{i}.git.{s}"
else:
git_version = new_version
except subprocess.CalledProcessError:
git_version = new_version

return git_version

VERSION = get_version()

print("Version: ", VERSION)

if VERSION and "-" in VERSION:
# when not on tag, git describe outputs: "1.3.3-22-gdf81228"
# pip has gotten strict with version numbers
# so change it to: "1.3.3+22.git.gdf81228"
# See: https://peps.python.org/pep-0440/#local-version-segments
v,i,s = VERSION.split("-")
VERSION = v + "+" + i + ".git." + s

# assert "-" not in cf_remote_version
# assert "." in cf_remote_version

# assert os.path.isfile("cf_remote/version.py")
# with open("cf_remote/VERSION", "w", encoding="utf-8") as fh:
# fh.write("%s\n" % cf_remote_version)

# with open("README.md", "r", encoding="utf-8") as fh:
# long_description = fh.read()

DESCRIPTION = 'A simple library for Python beginners'

# Setting up
setup(
name="easyPythonpi",
version=VERSION,
Expand All @@ -90,14 +12,16 @@ def get_version():
description=DESCRIPTION,
long_description_content_type="text/markdown",
packages=find_packages(),
install_requires=["numpy >= 1.19.5"] + (["requests >= 2.25.1"] if not requests_installed else []),
setup_requires=["requests >= 2.25.1"],
keywords=['python', 'sorting', 'beginners', 'sockets'],
install_requires=[
"numpy>=1.19.5",
"requests>=2.25.1",
],
keywords=["python", "sorting", "beginners", "sockets"],
classifiers=[
"Development Status :: 1 - Planning",
"Programming Language :: Python :: 3",
"Operating System :: Unix",
"Operating System :: MacOS :: MacOS X",
"Operating System :: Microsoft :: Windows",
]
],
)
Loading