Invocation.build renamed to Invocation.reflect#2
Open
arepnikov wants to merge 1 commit intoeventide-project:masterfrom
Open
Invocation.build renamed to Invocation.reflect#2arepnikov wants to merge 1 commit intoeventide-project:masterfrom
arepnikov wants to merge 1 commit intoeventide-project:masterfrom
Conversation
This was referenced Dec 27, 2023
Contributor
|
In case any users have coupled to Invocation.build, we should add an alias with a deprecation warning. However, we need to determine a standard format for deprecation warnings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1 (Rename build constructor to reflect)
Background
Invocation's constructor is named
.build, but it should have been named.reflect.Current Behavior
Proposed Change
Dependent gems
There are two Eventide libraries that reference
Invocation.build,mimicandrecord-invocation. Pull requests that update those references toInvocation.reflecthave been submitted: