This repository was archived by the owner on Jun 10, 2021. It is now read-only.
Fixed some errors in documentation (cookbook)#16
Open
jtakalai wants to merge 1 commit intoethers-io:masterfrom
Open
Fixed some errors in documentation (cookbook)#16jtakalai wants to merge 1 commit intoethers-io:masterfrom
jtakalai wants to merge 1 commit intoethers-io:masterfrom
Conversation
Fixes are based on actually running the code, see https://github.com/jtakalai/ethers-cookbook/blob/master/non-constant-return.js The "runnable form" cookbook could be good also in that it could be tested against actual ethers.js deployments. Maybe cookbook code should become tests in ethers.js?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes are based on actually running the code, see https://github.com/jtakalai/ethers-cookbook/blob/master/non-constant-return.js
The "runnable form" cookbook could be good also in that it could be tested against actual ethers.js deployments. Maybe cookbook code should become tests in ethers.js?