Conversation
Reviewer's Guide by SourceryThis PR adds Docker image support to the project by modifying the cookiecutter configuration to include a new option for Docker image generation. Architecture diagram for Docker image integrationgraph TD;
A[Project Configuration] -->|Modified| B[Cookiecutter Configuration];
B -->|Added| C[Docker Image Option];
C --> D[Docker Image Generation];
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @JaeAeich - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please complete the PR checklist. We need to ensure all requirements are met, particularly regarding documentation and testing.
- The PR description is empty except for the issue reference. Please provide context about what this Docker image support will entail and how it will be implemented.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
@uniqueg Docker build and push CI is still left, but since elixir's docker account name is |
uniqueg
left a comment
There was a problem hiding this comment.
LGTM except for the empty GH Actions workflow
| COPY pyproject.toml poetry.lock* /app/ | ||
|
|
||
| # Install dependencies | ||
| RUN poetry config virtualenvs.create false \ | ||
| && poetry install --no-interaction --no-ansi --only main | ||
|
|
||
| # Copy the rest of the application code | ||
| COPY . /app/ |
There was a problem hiding this comment.
Just put Copy . ., because pyproj will have README.md as requirement and some other files as well, this might fail poetry install.
| # Copy the rest of the application code | ||
| COPY . /app/ | ||
|
|
||
| ################################################### |
There was a problem hiding this comment.
Nothing will change in this layer, so there is no point of having an extra layer. Instead build the app in layer 2 and pip install wheel in this layer then that would make more sense.
| "add_script": "y", | ||
| "year": "{% now 'utc', '%Y' %}", | ||
| "add_pypi_release_ci": "y", | ||
| "add_docker_image": "y" |
There was a problem hiding this comment.
Json format error... please add . at the end.



Description
Checklist
project, including, in particular, with regard to any style guidelines
specification; in particular, it clearly indicates
that a change is a breaking change
using the PR title as the commit message
changed behavior
or updated existing ones (only for Python, TypeScript, etc.)
docstrings) for all packages/modules/functions/classes/
methods or updated existing ones
works
Comments
Summary by Sourcery
New Features: