Fix ArithmeticError in ServeShapePlug when parse_body halts before telemetry span#3929
Open
Fix ArithmeticError in ServeShapePlug when parse_body halts before telemetry span#3929
Conversation
…meticError When parse_body halted a request before start_telemetry_span had executed, the custom halt/1 would call end_telemetry_span which tried to compute `System.monotonic_time() - nil`, causing an ArithmeticError. Fixes #3919 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3929 +/- ##
=======================================
Coverage 75.75% 75.75%
=======================================
Files 11 11
Lines 693 693
Branches 174 172 -2
=======================================
Hits 525 525
Misses 167 167
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
These tests verify that POST requests with invalid JSON or non-object JSON bodies return proper 400 responses without crashing. Before the plug ordering fix, these paths would trigger an ArithmeticError in end_telemetry_span. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_bodyplug afterstart_telemetry_spanin the pipeline to preventArithmeticErrorwhenparse_bodyhalts (e.g. oversized body, bad JSON) before the telemetry span is initializedhalt/1callsend_telemetry_span()which tried to computeSystem.monotonic_time() - nil, crashing the requestFixes #3919
Test plan
serve_shape_plug_test.exstests pass (31 tests, 0 failures)🤖 Generated with Claude Code