Changelogs: add commands for PR/artifact evaluation#2862
Open
Changelogs: add commands for PR/artifact evaluation#2862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new evaluation pipeline for changelog-related GitHub Actions, adding support for artifact-based cross-workflow state transfer and robust PR evaluation. The changes include new services for evaluating PRs and artifacts, new argument and metadata types, enhancements to label-based blocking logic, and updates to documentation and test visibility.
New CI Evaluation Pipeline for Changelog Generation:
New evaluation services and workflow artifacts:
ChangelogPrEvaluationService,ChangelogPrepareArtifactService, andChangelogArtifactEvaluationServiceclasses to handle PR evaluation, artifact preparation, and artifact evaluation in CI workflows. These services manage PR eligibility, artifact packaging, and artifact validation, enabling robust cross-workflow state transfer for changelog generation. [1] [2] [3]EvaluatePrArguments,PrepareArtifactArguments,EvaluateArtifactArguments) and a metadata record (ChangelogArtifactMetadata) for structured data exchange between workflows. [1] [2] [3] [4]PrEvaluationResultenum to standardize PR evaluation outcomes.Label-based blocking and PR info improvements:
PrInfoProcessorwith new static methods (AreAllProductsBlocked,IsBlockedByRules) to determine if all products are blocked by PR labels, supporting per-product and global rules.GitHubPrInfoto includeHeadSha,HeadRef, andIsForkproperties to support more accurate PR state tracking.Documentation and test visibility:
changelog evaluate-pr,changelog prepare-artifact, andchangelog evaluate-artifactcommands for CI workflows.InternalsVisibleTofor theElastic.Changelog.Testsassembly to enable internal testing of new logic.GitHub.Actions.Corefor integration with GitHub Actions.