Add option to read API key from file #5
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. Passing the secrets trough the commandline is security risk as any user on the machine can read the secret while the container is running. Page is suggesting to run:
I ran it as jhenner and then as a guest I can observe the password while the container is running by:
The base for the fix I am proposing enables the user to pass the secret trough a file on the filesystem, effectively hiding it from the ps aux and when used with the docker/podman secrets, it won't be part of the image as well as this file is mounted similarly as volume.
https://docs.docker.com/engine/swarm/secrets/
Another important aspect of this is that with the proper handling of the secrets, one can easily share the
compose.ymlfile without exposing the secrets to the world which would be the case if the secret was passed as the command line parameter.