Skip to content

Footnote scrollable, when > 10 #2238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mariusheine merged 2 commits into from
Mar 9, 2026
Merged

Footnote scrollable, when > 10 #2238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d1e0a7
Footnote scrollable, when > 10
TruongQuangSB Mar 6, 2026
94f1831
Visible scroll by necessary
TruongQuangSB Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions java/bundles/org.eclipse.set.basis/src/org/eclipse/set/basis/constants/ToolboxConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,11 @@ public interface CacheId {
*/
public static final String EXAMPLE_PROJECT_1_10_0_3 = "PPHN_01-02_IbnZ2AeM_2026-02-02_17-47.planpro";

/**
* The minimum of footnotes count to active horizontal scroll
*/
public static final int FOOTNOTE_ACTIVE_SCROLL_MINIMUM = 10;

/**
* The tolerance value between TOP_Kante length and the sum of GEO_Kanten
* length, which belong to this TOP_Kante (in Meter)
Expand Down
15 changes: 10 additions & 5 deletions ...les/org.eclipse.set.feature.table/src/org/eclipse/set/feature/table/ToolboxTableView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,11 @@ private void updateFootnotes() {
startOffset += text.length() + 1;

}

if (lines.size() > ToolboxConstants.FOOTNOTE_ACTIVE_SCROLL_MINIMUM) {
GridDataFactory.fillDefaults()
.grab(true, true)
.applyTo(tableFooting);
}
tableFooting.setText(StringUtils.join(lines, "\n")); //$NON-NLS-1$
tableFooting.setStyleRanges(styles.toArray(new StyleRange[0]));
}
Expand Down Expand Up @@ -555,14 +559,15 @@ protected void createView(final Composite parent) {
bodyLayerStack.getSelectionLayer().clear();

// display footnotes
tableFooting = new StyledText(parent, SWT.MULTI);
tableFooting.setBackground(GRAY_BACKGROUND);
updateFootnotes();
tableFooting.setEditable(false);
tableFooting = new StyledText(parent, SWT.MULTI | SWT.V_SCROLL);
GridDataFactory.fillDefaults()
.grab(true, false)
.minSize(-1, 500)
.applyTo(tableFooting);
tableFooting.setBackground(GRAY_BACKGROUND);
tableFooting.setAlwaysShowScrollBars(false);
updateFootnotes();
tableFooting.setEditable(false);

// export action
getBanderole().setExportAction(new SelectableAction() {
Expand Down
Loading