You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Resolves the feature flag for disabling local cache by letting the caller pass it in. API retains it, client proxy loses it.
Note
Medium Risk
Medium risk because it changes runtime caching behavior for sandbox routing lookups (potential latency increase on client proxies and different cache consistency characteristics), and removes a feature-flag fallback path.
Overview
This PR removes the SandboxCatalogLocalCacheFlag and instead makes Redis sandbox catalog local caching an explicit useLocalCache constructor parameter, with client-proxy now constructing the catalog with caching disabled while the API orchestrator keeps caching enabled. The Redis catalog implementation is updated to treat the cache as optional (nil) and the unit test is rewritten to assert behavior with caching enabled vs disabled without relying on feature-flag targeting.
Written by Cursor Bugbot for commit f40d8ed. This will update automatically on new commits. Configure here.
Medium Risk
Medium risk because it changes sandbox routing lookup caching behavior and the NewRedisSandboxesCatalog API, which could impact request latency or cache lifecycle if callers don’t enable/close the cache correctly.
Overview
Makes the Redis-backed sandbox catalog’s local read-through cache explicitly opt-in via a ReadThroughCache() constructor option, removing the LaunchDarkly flag (sandbox-catalog-local-cache) and related feature-flag plumbing. client-proxy now uses the Redis catalog without a local cache, while the API orchestrator explicitly enables the cache; tests are updated to cover cached vs non-cached behavior and the catalog now guards cache operations when caching is disabled.
Written by Cursor Bugbot for commit 8f3ff83. This will update automatically on new commits. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the feature flag for disabling local cache by letting the caller pass it in. API retains it, client proxy loses it.
Note
Medium Risk
Medium risk because it changes runtime caching behavior for sandbox routing lookups (potential latency increase on client proxies and different cache consistency characteristics), and removes a feature-flag fallback path.
Overview
This PR removes the
SandboxCatalogLocalCacheFlagand instead makes Redis sandbox catalog local caching an explicituseLocalCacheconstructor parameter, withclient-proxynow constructing the catalog with caching disabled while the API orchestrator keeps caching enabled. The Redis catalog implementation is updated to treat the cache as optional (nil) and the unit test is rewritten to assert behavior with caching enabled vs disabled without relying on feature-flag targeting.Written by Cursor Bugbot for commit f40d8ed. This will update automatically on new commits. Configure here.