feat: unify kill confirm dialog and add pause button to sandbox controls#278
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
feat: unify kill confirm dialog and add pause button to sandbox controls#278devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
- Replace AlertPopover with AlertDialog for kill sandbox confirmation
to match the centered modal style used by other destructive actions
- Add pause sandbox server action using POST /sandboxes/{sandboxID}/pause
- Add PauseButton component with confirmation dialog
- Add PauseButton to sandbox detail controls alongside KillButton
Co-Authored-By: vasek <vasek.mlejnsky@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two changes based on dashboard feedback:
Kill button confirm dialog unified: Replaced
AlertPopover(small popover anchored to button) withAlertDialog(centered modal) to match the confirmation pattern used by other destructive actions (delete API key, delete template, etc.).Pause button added: New "Pause" button in sandbox detail controls, placed alongside the existing Kill button. Calls
POST /sandboxes/{sandboxID}/pausevia a new server action. Only enabled when the sandbox is inrunningstate.Review & Testing Checklist for Human
AlertDialogconfirm button renders withvariant="error"(red) by default. Pause is a non-destructive action (sandbox can be resumed) — consider whether this should use a different button variant or skip the confirmation dialog entirely.AlertDialogmodal looks correct and matches other delete confirmation dialogs in the dashboard.Notes
AlertPopovercomponent is no longer used anywhere after this change — it could be cleaned up in a follow-up if desired.Link to Devin session: https://app.devin.ai/sessions/314098a637d54189bbae52a319cb216b
Requested by: @mlejva