Skip to content

Replace kill button popover with AlertDialog#277

Open
beran-t wants to merge 1 commit intomainfrom
kill-confirm-dialog
Open

Replace kill button popover with AlertDialog#277
beran-t wants to merge 1 commit intomainfrom
kill-confirm-dialog

Conversation

@beran-t
Copy link
Contributor

@beran-t beran-t commented Mar 24, 2026

Summary

  • Replaced AlertPopover with AlertDialog on the sandbox kill button to match the confirmation dialog pattern used throughout the dashboard (webhook deletion, team leave, API key revocation, etc.)
  • Added loading state with Loader component and error variant styling, consistent with the webhook delete dialog

Test plan

  • Open sandbox detail page, click "Kill" button, verify AlertDialog appears
  • Confirm the dialog matches the style of other AlertDialogs (e.g., webhook delete)
  • Verify killing a sandbox still works end-to-end
  • Verify the button is disabled when sandbox is already killed

Use the standard AlertDialog component for the kill confirmation,
matching the pattern used by other destructive action dialogs in the
dashboard (webhook deletion, team leave, etc.).
@beran-t beran-t requested a review from ben-fornefeld as a code owner March 24, 2026 15:26
@vercel
Copy link

vercel bot commented Mar 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web Ready Ready Preview, Comment Mar 24, 2026 3:27pm
web-juliett Ready Ready Preview, Comment Mar 24, 2026 3:27pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant