Migrate service model base url #3560
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/v1`) if `model` has `openai` format. - Add CORS support to the gateway service endppoint (if `model` has `openai` format)
…the same model name
… backward compatibility (with older verions of gateway)
Now that service.model.base_url points to service.url + /v1 for openai-format models, it is no longer deprecated and can be recommended as the model endpoint. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate
service.model.base_urlfrom the deprecatedgateway.{domain}model aggregation endpoint to the service endpoint foropenai-format models.service.model.base_url: Foropenaiformat, set toservice_url + prefix(e.g.https://run-name.domain.com/v1). For other formats, keep the existinggateway.{domain}URL.prefixfield instead of hardcoding/v1.service.jinja2nginx template, enabled only for services withopenai-format models. Strips upstream CORS headers to avoid duplicates.cors_enabledonServicemodel: Store CORS flag per-service for correctness with multiple services. Includes a startup migration for gateways with pre-existing state.