[Gandiva] Complete timestamp precision support for all datetime functions#129
Draft
telemenar wants to merge 10000 commits intodremio:dremiofrom
Draft
[Gandiva] Complete timestamp precision support for all datetime functions#129telemenar wants to merge 10000 commits intodremio:dremiofrom
telemenar wants to merge 10000 commits intodremio:dremiofrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the implementation of timestamp precision support for all Gandiva datetime functions, building on the infrastructure established in #128.
Changes
Phase 4: Extract Functions
extractMonth,extractDay,extractHour,extractMinute,extractSecondfor all precisionsextractDoy,extractDow,extractQuarter,extractWeekfor all precisionsextractEpoch,extractMillennium,extractCentury,extractDecadefor all precisionsPhase 5: Date Truncation Functions
date_trunc_Second/Minute/Hour/Day/Week/Month/Quarter/Yearfor all precisionsdate_trunc_Decade/Century/Millenniumfor all precisionsdate_trunc_Millisecond(for us/ns) anddate_trunc_Microsecond(for ns)Phase 6: Timestamp Arithmetic Functions
timestampaddSecond/Minute/Hour/Day/Weekfor all precisionstimestampaddMonth/Quarter/Yearfor all precisions(int, timestamp)and(timestamp, int)Phase 7: Cast and Conversion Functions
castDATEfor all timestamp precisionscastTIMEfor all timestamp precisionsdatedifffor all timestamp precisionsPhase 8: Remaining Functions
months_betweenfor all timestamp precisionslast_dayfor all timestamp precisionsFunctions Implemented
Testing
Dependencies
Co-authored by Augment Code
Pull Request opened by Augment Code with guidance from the PR author