Skip to content

DX-113970 Fix macos build by updating runner#125

Merged
akravchukdremio merged 5 commits intodremio:dremio_25.1_16.1.0from
akravchukdremio:DX-113970-25.2-bis
Mar 18, 2026
Merged

DX-113970 Fix macos build by updating runner#125
akravchukdremio merged 5 commits intodremio:dremio_25.1_16.1.0from
akravchukdremio:DX-113970-25.2-bis

Conversation

@akravchukdremio
Copy link

The build-arrow job is failing: https://github.com/Vijeth-test/arrow-build/actions/runs/22256780098/job/64401087864 with error The configuration 'macos-13-us-default' is not supported.

I've checked 26.1 branch and find out these changes: 00f53d4 - so I've cherry-picked them to fix the issue. So old macos runner with version 13 is not supported, I've changed to 15

@akravchukdremio akravchukdremio self-assigned this Feb 25, 2026
lriggs
lriggs previously approved these changes Feb 25, 2026
DenisTarasyuk and others added 2 commits March 17, 2026 16:53
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
akravchukdremio and others added 2 commits March 17, 2026 17:42
apacheGH-42149: [C++] Use FetchContent for bundled ORC (apache#43011)

This also has a workaround for https://issues.apache.org/jira/browse/ORC-1732 .

ORC 2.0.1 has a dependency detection problem. We can't override the detection with ExternalProject but can override the detection with FetchContent.

Yes.

Yes.
* GitHub Issue: apache#42149

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
@akravchukdremio
Copy link
Author

Based on the PR for 25.3 version: #124 I've cherry-picked fixes for removing failing windows build (fef85e3 and 31776a0) and for upgrading download-artifact action from v3 to v4 (15158bd) to fix the build.

There was an issue with installing custom cmake in macos runner: https://github.com/Vijeth-test/arrow-build/actions/runs/23200736647/job/67422006684#step:5:144 - that's why I've cherry picked this change: 45d8010#diff-c62ecdb3dd583968ea80240bc06da8b8f477220cce4ad11bd1b23d42f8e44894. But it was not enough, because I faced with another issue: here https://github.com/Vijeth-test/arrow-build/actions/runs/23202994428/job/67430385241#step:6:828 build has failed due to cmake error furing building Apache orc only on macos arm instance. I've found similar github issue in open-source arrow with same logs: apache#42149 which was fixed by such PR: apache#43011 - that's why I've cherry-picked respective commit: apache@e8a795b which was already in 25.3, but was missing in 25.2.

build has successfully run: https://github.com/Vijeth-test/arrow-build/actions/runs/23219867470 - so this is a final fix

@akravchukdremio akravchukdremio requested a review from lriggs March 18, 2026 01:29
@akravchukdremio akravchukdremio merged commit a2de9b5 into dremio:dremio_25.1_16.1.0 Mar 18, 2026
2 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants