Draft
Conversation
Co-authored-by: blakeinvictoria <blakeinvictoria@gmail.com>
|
Cursor Agent can help with this pull request. Just |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bugbot free trial expires on September 9, 2025
Learn more in the Cursor dashboard.
| """Generate strict bash mode settings.""" | ||
| # Default strict mode: exit on error, undefined vars, pipe failures | ||
| return "set -eou --pipefail" | ||
|
|
There was a problem hiding this comment.
Bug: Bash Syntax Error in set_strict Macro
The set_strict macro generates invalid bash syntax with set -eou --pipefail. Bash's set command doesn't support --pipefail; it requires -o pipefail. Additionally, the -o flag in -eou expects an argument, making the combined flags incorrect. This will lead to runtime syntax errors.
…ndling Co-authored-by: blakeinvictoria <blakeinvictoria@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
# set strictand# trap cleanupsafety macros to lower the mental load for robust bash scripting.Linear Issue: CLI-32