Open
Conversation
Co-authored-by: blakeinvictoria <blakeinvictoria@gmail.com>
|
Cursor Agent can help with this pull request. Just |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bugbot free trial expires on September 9, 2025
Learn more in the Cursor dashboard.
| except ValueError as e: | ||
| # Skip invalid annotations, or raise depending on desired behavior | ||
| print(f"Warning: Invalid annotation for {var_name}: {e}") | ||
| continue |
There was a problem hiding this comment.
Bug: Choice Validation Breaks Backward Compatibility
The new validation for choice type annotations breaks backward compatibility. Annotations like # VAR (choice): Description (without explicit choices) now fail validation and are skipped, changing behavior for existing valid annotations. Additionally, validation errors are printed directly to stdout, which isn't standard for a library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement an argument type class system to replace string-based type handling for improved extensibility and validation (CLI-30).
This PR introduces
BaseArgumentTypeand its subclasses (e.g.,StringType,IntType,ChoiceType) to manage argument types. This refactors the previous string-basedif/elsechains, allowing each type to define its annotation strings,argparsetype, and custom validation logic, making the system more robust and easier to extend.Linear Issue: CLI-30