Allow variable overwriting, exclude loop variables#31
Draft
BlakeASmith wants to merge 2 commits intomainfrom
Draft
Allow variable overwriting, exclude loop variables#31BlakeASmith wants to merge 2 commits intomainfrom
BlakeASmith wants to merge 2 commits intomainfrom
Conversation
Co-authored-by: blakeinvictoria <blakeinvictoria@gmail.com>
|
Cursor Agent can help with this pull request. Just |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bugbot free trial expires on September 9, 2025
Learn more in the Cursor dashboard.
| assert rc == 0 | ||
| out = capsys.readouterr().out | ||
| assert "(default from script: false)" in out or "(default from script: true)" in out | ||
| assert "(default from script: 30)" in out No newline at end of file |
There was a problem hiding this comment.
Bug: Test Fails to Enforce Strict Boolean Default Handling
The test_defined_defaults_help_shows_script_defaults test's assertion for the DEBUG variable is overly permissive. Since the script explicitly sets DEBUG=false, the help output should strictly show (default from script: false). Accepting true as well could mask issues with how boolean default values are parsed or displayed.
Co-authored-by: blakeinvictoria <blakeinvictoria@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow overriding top-level script-defined variables via CLI arguments, using their script values as defaults.