Enhancement: Add Python 3.12 and 3.13 #159
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ansion Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…rough an exception Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
jenniferjiangkells
requested changes
Dec 15, 2025
Member
jenniferjiangkells
left a comment
jenniferjiangkells
left a comment
There was a problem hiding this comment.
The approach looks sound to me. The most important thing is that it's backward compatible with the cookbook examples and sets up a solid foundation for future improvements, and this ticks the box.
I've made some general comments, but tbh the only change absolutely needed is removing spyne as a dependency in the pyproject.toml.
| # For FastAPI apps, use mount | ||
| self.mount(mount_path, router_or_app) | ||
| endpoints_registry[service_name].add(f"MOUNTED:{mount_path}") | ||
| logger.info(f"✅ Mounted app {service_name} at {mount_path}") |
adamkells
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds functionality for python 3.12
Address #127
This is achieved by removing Spyne as a dependency for SOAP servers.
In particular, we add a FastAPI server and a WSDL file while removing spyne and associated files.
Changes Made
Python 3.12 is added as an acceptable python version. The ci/cd will now additionally run on 3.12 as a test version. The publishing of the package will also be done on 3.12
Testing
Vibe coded tests were run, existing tests were modified to run on new code.
Additionally the Cookbook example for connecting to Medplum was confirmed to run and give the same output before and after.
Checklist