Conversation
There was a problem hiding this comment.
Review Summary
No issues found in the changed code! ✅
This PR successfully restructures the CLI commands as intended:
Changes Reviewed
- ✅ Default to
runcommand: ThedefaultToRunfunction is well-implemented with comprehensive test coverage - ✅ Command reorganization: Moving server commands under
serveand sharing commands undershareis clean and straightforward - ✅ Exec integration: The
--execflag properly replaces the standaloneexeccommand with good telemetry tracking - ✅ Telemetry updates: All telemetry tracking correctly reflects the new command structure
- ✅ Code quality: The new functions have proper documentation and edge case handling
The command restructuring achieves the goal of simplifying the top-level CLI while maintaining backward compatibility through the new flags and subcommands.
7fabede to
92cf2d2
Compare
rumpl
previously approved these changes
Feb 16, 2026
krissetto
previously approved these changes
Feb 16, 2026
Contributor
krissetto
left a comment
There was a problem hiding this comment.
nice! lets remember to call out some of these as breaking changes in the changelog
Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
…ange) Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
When invoked without a subcommand (e.g. bare "cagent" or "cagent --debug"), automatically prepend "run" so the default agent is launched. Users can still use "cagent --help" to list available commands. Assisted-By: cagent
Signed-off-by: David Gageot <david.gageot@docker.com>
92cf2d2 to
74733c8
Compare
trungutt
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that
cagentwithout command is a synonym ofcagent runThis is to make the first usage more straightforward. No need to guess which command to
use. Just run
cagent.Of course more work needs to be done to handle users without API keys. but that's a first step.
Remove little used commands
Those commands are more confusing than useful.
cagent config showcagent config pathcagent feedbackcagent buildcagent catalog listMove server commands under
cagent serveReduce the list of top level commands that are very advanced use cases.
cagent api->cagent serve apicagent a2a->cagent serve a2acagent mcp->cagent serve mcpcagent acp->cagent serve acpHide
cagent debugcommandReplace
cagent execwithcagent run --execThose two commands were already sharing the same flags and same code.
It removes a
corecommand that is probably more an advanced use case.Move sharing commands under
cagent shareIt clearer that the purpose of to commands is to share agents.
We could add more sub-commands in the future that do not end up at the top level.
cagent pull->cagent share pullcagent push->cagent share push