refactor(sandbox): extract Runner interface and move Docker runner to pkg/sandbox#1639
Open
tdabasinskas wants to merge 1 commit intodocker:mainfrom
Open
refactor(sandbox): extract Runner interface and move Docker runner to pkg/sandbox#1639tdabasinskas wants to merge 1 commit intodocker:mainfrom
pkg/sandbox#1639tdabasinskas wants to merge 1 commit intodocker:mainfrom
Conversation
… pkg/sandbox Introduce a pluggable sandbox.Runner interface to decouple shell tool execution from the Docker sandbox implementation. This enables adding alternative sandbox backends without modifying the shell tool itself. Changes: - Add sandbox.Runner interface in pkg/sandbox/runner.go - Move and refactor Docker sandbox from pkg/tools/builtin/sandbox.go to pkg/sandbox/docker.go, implementing the Runner interface - Update ShellTool to accept sandbox.Runner instead of the concrete *sandboxRunner type - Update registry to create sandbox.DockerRunner and pass it to ShellTool Signed-off-by: Tomas Dabašinskas <tomas.dabasinskas@cogvel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a pluggable
sandbox.Runnerinterface to decouple shell tool execution from the Docker sandbox implementation. This enables adding alternative sandbox backends without modifying the shell tool itself.Changes:
pkg/sandbox/runner.gopkg/tools/builtin/sandbox.gotopkg/sandbox/docker.go, implementing the Runner interfaceShellToolto acceptsandbox.Runnerinstead of the concrete*sandboxRunnertypesandbox.DockerRunnerand pass it toShellTool@dgageot, FYI (I see you added the initial support for Sandbox under #1209).