RPC Rework: With Var Renames #1143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lueprint to be consistent with docs
jeff-hykin
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| @@ -0,0 +1,56 @@ | |||
| # Copyright 2026 Dimensional Inc. | |||
Contributor
There was a problem hiding this comment.
Should this example be in the docs? I don't think anyone will look at it here.
Member
Author
There was a problem hiding this comment.
I should have updated blueprints.md for the docs and the had this as a standalone example for people who jump into the code. (I believe this dir is linked to somewhere in the docs)
paul-nechifor
previously approved these changes
Jan 29, 2026
| return a * b | ||
|
|
||
| @rpc | ||
| def start(self) -> None: ... |
Contributor
There was a problem hiding this comment.
You need super().start() here and stop in the others.
paul-nechifor
approved these changes
Jan 31, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.