Safari doesn’t support OPFS createWritable method#13
Open
rjmunro wants to merge 2 commits intodiffusionstudio:mainfrom
Open
Safari doesn’t support OPFS createWritable method#13rjmunro wants to merge 2 commits intodiffusionstudio:mainfrom
rjmunro wants to merge 2 commits intodiffusionstudio:mainfrom
Conversation
So we have to use a Synchronous write method, which is only available if we are running in a web worker. Put a warning to console if we are not, and don’t leave behind an empty file.
This means you can use a line in package.json like:
"@diffusionstudio/vits-web": "git@github.com: diffusionstudio/vits-web.git#[SHA]",
to test a specific SHA version in another project before it's released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead we have to use a Synchronous write method, which is only available if we are running in a web worker.
If we are not running in a worker, put a warning to console, and don’t leave behind an empty file.