Skip to content

docs: Add skills for OISY Wallet Signer#16

Merged
marc0olo merged 20 commits intomainfrom
docs/Add-skills-for-OISY-Wallet-Signer
Mar 4, 2026
Merged

docs: Add skills for OISY Wallet Signer#16
marc0olo merged 20 commits intomainfrom
docs/Add-skills-for-OISY-Wallet-Signer

Conversation

@AntonioVentilii
Copy link
Collaborator

@AntonioVentilii AntonioVentilii commented Feb 26, 2026

Adding the SKILL.md file for the repo OISY Wallet Signer.

Credits: @artkorotkikh-dfinity

Copy link
Collaborator

@JoshDFN JoshDFN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good — solid skill file. Note: the dependencies field lists npm packages but should list skill IDs (other skills in this repo). The npm deps belong in a requires frontmatter field instead. Also category: Wallet isn't in the current category list — may need to pick an existing one or we add it. Minor stuff, happy to merge once you take it out of draft.

@JoshDFN
Copy link
Collaborator

JoshDFN commented Feb 26, 2026

Hey Antonio — approved! One small thing: the dependencies field in frontmatter is for referencing other skill IDs in this repo (e.g., [icrc-ledger, wallet]), not npm packages. Your npm deps should go in a requires field instead:

dependencies: []
requires: [@dfinity/utils >= 4.1, @dfinity/zod-schemas >= 3, @icp-sdk/canisters >= 3.2, @icp-sdk/core >= 5, zod >= 4]

Ready to merge once you fix that and take it out of draft!

@JoshDFN JoshDFN mentioned this pull request Feb 26, 2026
Copy link

@sbpublic sbpublic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, here my review, part I

@AntonioVentilii AntonioVentilii marked this pull request as ready for review March 2, 2026 12:02
@marc0olo
Copy link
Member

marc0olo commented Mar 2, 2026

#55 just merged and removed the README skills table (among other changes). This PR now has a merge conflict in README.md.

The README no longer lists individual skills — you can drop your README changes entirely. Only skills/oisy-wallet-signer/SKILL.md needs to be in the PR.

Also, the frontmatter format changed. The new format is:

---
name: oisy-wallet-signer
description: "..."
license: Apache-2.0
compatibility: "icp-cli >= 0.1.0"
metadata:
  title: "OISY Wallet Signer"
  category: Wallet
---

Removed fields: version, endpoints, status, dependencies, requires, tags. See CONTRIBUTING.md for the full reference.

Please rebase on main and update accordingly.

@marc0olo
Copy link
Member

marc0olo commented Mar 4, 2026

now we are good to go, thanks a lot @AntonioVentilii :)

@marc0olo marc0olo merged commit 95987c2 into main Mar 4, 2026
6 checks passed
@marc0olo marc0olo deleted the docs/Add-skills-for-OISY-Wallet-Signer branch March 4, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants