Conversation
JoshDFN
left a comment
There was a problem hiding this comment.
Looks good — solid skill file. Note: the dependencies field lists npm packages but should list skill IDs (other skills in this repo). The npm deps belong in a requires frontmatter field instead. Also category: Wallet isn't in the current category list — may need to pick an existing one or we add it. Minor stuff, happy to merge once you take it out of draft.
|
Hey Antonio — approved! One small thing: the dependencies: []
requires: [@dfinity/utils >= 4.1, @dfinity/zod-schemas >= 3, @icp-sdk/canisters >= 3.2, @icp-sdk/core >= 5, zod >= 4]Ready to merge once you fix that and take it out of draft! |
|
#55 just merged and removed the README skills table (among other changes). This PR now has a merge conflict in The README no longer lists individual skills — you can drop your README changes entirely. Only Also, the frontmatter format changed. The new format is: ---
name: oisy-wallet-signer
description: "..."
license: Apache-2.0
compatibility: "icp-cli >= 0.1.0"
metadata:
title: "OISY Wallet Signer"
category: Wallet
---Removed fields: Please rebase on |
|
now we are good to go, thanks a lot @AntonioVentilii :) |
Adding the
SKILL.mdfile for the repo OISY Wallet Signer.Credits: @artkorotkikh-dfinity