Improve JBoss EAP detection #284
Conversation
|
Hi @elsony @michael-valdron @Jdubrick @thepetk , could you please help to review this PR, thanks! |
Signed-off-by: HaoZhang <haozhan@microsoft.com>
Signed-off-by: HaoZhang <haozhan@microsoft.com> # Conflicts: # test/apis/component_recognizer_test.go
haoozhang
force-pushed
the
haozhan/jboss-eap
branch
from
22b1e15 to
4446a33
Compare
Signed-off-by: HaoZhang <haozhan@microsoft.com>
haoozhang
force-pushed
the
haozhan/jboss-eap
branch
from
99dbe30 to
51c2b44
Compare
|
Hey @haoozhang! Thank you for your PR! I'll take a look in the next days :) |
thepetk
left a comment
thepetk
left a comment
There was a problem hiding this comment.
/lgtm
Nice work @haoozhang!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoozhang, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Just a tiny comment before we merge. Regarding the test resources we are adding, We could think of reducing their size, after all we are only checking a specific file to find the framework/language. |
2 participants
Description of Changes
This PR is to improve the detection of JBoss EAP framework.
Related Issue(s)
Link the GitHub/GitLab/JIRA issues that are related to this PR.
Acceptance Criteria
Testing and documentation do not need to be complete in order for this PR to be approved. However, tracking issues must be opened for missing testing/documentation.
Unit/Functional tests
Documentation
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
[x] For each added clue, add the test project and unit test to verify it.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.
References