Skip to content

Conversation

@msrathore-db
Copy link
Contributor

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Other

Description

Fixed the exception handler close() on _TelemetryClientHolder objects instead of accessing the client inside them.

How is this tested?

  • Unit tests
  • E2E Tests
  • Manually
  • N/A

Related Tickets & Documents

…bjects instead of accessing the client inside them.
@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@nikhilsuri-db
Copy link
Contributor

Should we add more configuration like check_untyped_defs disallow_untyped_defs warn_return_any warn_unused_ignores in mypy tool to identify such issues early or at least let the developer know?

@samikshya-db
Copy link
Contributor

Sorry, might not be aware of this - Can you give more context on this change and how was this caught?

@msrathore-db
Copy link
Contributor Author

Sorry, might not be aware of this - Can you give more context on this change and how was this caught?

Was testing something with python connector but got an error from the server, which led to seeing this exception. The close() didn't exist in the class so made this small fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants