-
Notifications
You must be signed in to change notification settings - Fork 1
docs: generate API reference docs from TS packages #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9859832 to
182afcc
Compare
5dff24e to
1772a00
Compare
fcea296 to
837ec89
Compare
1772a00 to
1dd8ddc
Compare
1dd8ddc to
85f0054
Compare
| @@ -0,0 +1,17 @@ | |||
| # Function: Accordion() | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are all these auto generated?
|
After checking the docs, not so much the code, I find this a bit confusing:
I imagine there are other PRs to come so we complete the documentation, but I'm not sure what's the purpose of this one, I'm probably missing the step in between this PR and the last version We can discuss this when you are back @pkosiec |
|
Thanks @MarioCadenas for your input. This PR is a baseground for having a proper API reference doc. Unfortunately we're quite behind with the code documentation. We should be cautious what we export (and whether the stuff is internal or external). I didn't want to do more comments modifications as this PR with generated changes is too huge already but your comment is totally valid so I'll push some of them already 👍 appkit
Makes sense, I'll mark it as an
Agree, made most of the items internal, renamed This is how it looks like now after changes:
Not sure what to do with the functions? Should we mark most of them as internal as well? appkit-uiYou're right, I tried to customize the component docs generation with the the solution we have in place, but sadly, it is very limited 😞 Let me check the other options 👍 |
85f0054 to
e1480a3
Compare
This reverts commit 884665e.


https://databricks.atlassian.net/browse/LKB-7605
API reference docs are generated on
pnpm docs:devorpnpm docs:build.Demo
docs.mp4