DAOS-18582 vos: fix picking up pages for pinning#17578
Merged
daltonbohning merged 1 commit intomasterfrom Feb 20, 2026
Merged
Conversation
As of now, this code path is used only by DTX commit/abort. The bug caused unrelated parts of the structure to be interpreted as page indices that were about to be pinned, instead of using only the page indices already added to the array. Because this part of the code determines both which pages should be pinned and whether additional pages would get pinned, it led to two outcomes: In the best case: DTX commit/abort operations were processed in smaller "chunks" than intended, which could result in performance degradation. In the worst case: The code reasoned a certain page indices are in the array where in fact they were not. As a result, some page indices never made it into the array and were never pinned. Later code assumed that all required pages have been pinned, so a missing page would ultimately lead to a crash. Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
|
Ticket title is 'pool/verify_dtx.py:VerifyDTXMetrics.test_verify_dtx_metrics - test timeout w/ stack traces' |
Nasf-Fan
approved these changes
Feb 20, 2026
Contributor
Nasf-Fan
left a comment
Nasf-Fan
left a comment
There was a problem hiding this comment.
It's great to catching that.
grom72
approved these changes
Feb 20, 2026
daltonbohning
deleted the
janekmi/DAOS-18582-fix-picking-up-pages-for-pinning
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of now, this code path is used only by DTX commit/abort. The bug caused unrelated parts of the structure to be interpreted as page indices that were about to be pinned, instead of using only the page indices already added to the array. Because this part of the code determines both which pages should be pinned and whether additional pages would get pinned, it led to two outcomes:
In the best case: DTX commit/abort operations were processed in smaller "chunks" than intended, which could result in performance degradation.
In the worst case: The code reasoned a certain page indices are in the array where in fact they were not. As a result, some page indices never made it into the array and were never pinned. Later code assumed that all required pages have been pinned, so a missing page would ultimately lead to a crash.
Steps for the author:
After all prior steps are complete: