DAOS-18602 common: pin PMDK version to 2.1.2-1 for release 2.6.x#17567
DAOS-18602 common: pin PMDK version to 2.1.2-1 for release 2.6.x#17567grom72 wants to merge 2 commits intorelease/2.6from
Conversation
|
Ticket title is 'Pin PMDK version on release/2.6 branch to 2.1.2-1' |
d490b49 to
26dcd82
Compare
All validation steps on release/2.6 branch use PMDK 2.1.2-1, the latest available in artifactory. This PR lets PMDK version to be change in artifactory without any impact to release/2.6 branch. Allow-unstable-test: true Skip-func-test-leap15: false Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
26dcd82 to
18fe1e4
Compare
utils/build.config
Outdated
| argobots=v1.2 | ||
| fuse=fuse-3.16.2 | ||
| pmdk=2.1.0 | ||
| pmdk=2.1.2 |
There was a problem hiding this comment.
i would prefer you break this PR into 2.
-
the changes in this file. utils/build.config. this can land without merge approval because this should have been updated a long time ago when the master version was updated forcing CI to use different RPMs than what we have in source builds. this should have been caught earlier, but oh well.
-
the pinning, which requires merge approval.
There was a problem hiding this comment.
i would prefer you break this PR into 2.
- the changes in this file. utils/build.config. this can land without merge approval because this should have been updated a long time ago when the master version was updated forcing CI to use different RPMs than what we have in source builds. this should have been caught earlier, but oh well.
- the pinning, which requires merge approval.
I have combined these two changes into one PR because both of them are similar fixes, that practically does not change anything in release/2.6 but they correct discrepancies between the state described by the specifications and the actual state.
daos.spec says that it requires PMDK 2.1.0-1 and such version will be selected when creating 2.6.5 TB, but it is not the valid, one as whole validation is done with PMDK 2.1.2-1:
[2026-02-18T14:47:25.029Z] libpmemobj x86_64 2.1.2-1.el8 daos-stack-deps-el-8-stable-local-artifactory 149 k
From the point of view of the DAOS product, this PR doesn't change anything or add any new functions or behaviour. It's mostly about documenting what's going on behind the scenes.
There was a problem hiding this comment.
i would prefer you break this PR into 2.
- the changes in this file. utils/build.config. this can land without merge approval because this should have been updated a long time ago when the master version was updated forcing CI to use different RPMs than what we have in source builds. this should have been caught earlier, but oh well.
- the pinning, which requires merge approval.
I have combined these two changes into one PR because both of them are similar fixes, that practically does not change anything in release/2.6 but they correct discrepancies between the state described by the specifications and the actual state. daos.spec says that it requires PMDK 2.1.0-1 and such version will be selected when creating 2.6.5 TB, but it is not the valid, one as whole validation is done with PMDK 2.1.2-1:
[2026-02-18T14:47:25.029Z] libpmemobj x86_64 2.1.2-1.el8 daos-stack-deps-el-8-stable-local-artifactory 149 kFrom the point of view of the DAOS product, this PR doesn't change anything or add any new functions or behaviour. It's mostly about documenting what's going on behind the scenes.
Sorry, but this is definitely not a documentation change. I do understand your point though.
Everyone using source builds is actually affected by this. And yes I understand it is required to make that source build change, because the RPMs and CI have been updated sometime before without updating source builds. this is why we usually land the source build updates right away to 2.6 since those are already updated in CI. and again I would suggest to separate that change to keep PRs limited to one thing at a time and this can be landed by gatekeeper with no merge approval.
Pinning a dependency in 2.6 will require merge approval. I am not making those rules up myself.. please talk to your manager if you think it should not or have another issue with that.
There was a problem hiding this comment.
i just suggested to split the changes to get the source build landed right away.. we do not need to wait for testing for that one. if you do not want to split them, that's fine and we can just wait till this is reviewed.
#17574 Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
|
Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17567/5/testReport/ |
All validation steps on release/2.6 branch use PMDK 2.1.2-1, the latest available in artifactory.
This PR lets PMDK version to be change in artifactory without any impact to release/2.6 branch.
Steps for the author:
After all prior steps are complete: