Skip to content

DAOS-18487 rebuild: retry fetch for zero iod_size with force degraded #17545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
liuxuezhao wants to merge 1 commit into
base: master
Choose a base branch
from
+22 −0
Draft

DAOS-18487 rebuild: retry fetch for zero iod_size with force degraded #17545

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/object/srv_obj_migrate.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,13 +685,27 @@ mrone_recx_vos2_daos(struct migrate_one *mrone, int shard, daos_iod_t *iods, int
mrone_recx_daos_vos_internal(mrone, false, shard, iods, iods_num);
}

static bool
mrone_get_zero_iod_size(daos_iod_t *iods, int iod_num)
{
int i;

for (i = 0; i < iod_num; i++) {
if (iods[i].iod_size == 0)
return true;
}

return false;
}

static int
mrone_obj_fetch_internal(struct migrate_one *mrone, daos_handle_t oh, d_sg_list_t *sgls,
daos_iod_t *iods, int iod_num, daos_epoch_t eph, uint32_t flags,
d_iov_t *csum_iov_fetch, struct migrate_pool_tls *tls)
{
uint32_t *extra_arg = NULL;
int waited = 0;
bool force_degraded = false;
int rc;

/* pass rebuild epoch by extra_arg */
Expand All @@ -703,6 +717,14 @@ mrone_obj_fetch_internal(struct migrate_one *mrone, daos_handle_t oh, d_sg_list_
retry:
rc = dsc_obj_fetch(oh, eph, &mrone->mo_dkey, iod_num, iods, sgls, NULL, flags, extra_arg,
csum_iov_fetch);
if ((rc == 0 && mrone_get_zero_iod_size(iods, iod_num)) && !force_degraded &&
!tls->mpt_fini) {
DL_INFO(rc, DF_RB ": retry " DF_UOID " fetch", DP_RB_MPT(tls),
DP_UOID(mrone->mo_oid));
force_degraded = true;
flags |= DIOF_FOR_FORCE_DEGRADE;
goto retry;
}
if ((rc == -DER_TIMEDOUT || rc == -DER_FETCH_AGAIN || rc == -DER_NOMEM) &&
tls->mpt_version + 1 >= tls->mpt_pool->spc_map_version) {
if (tls->mpt_fini) {
Expand Down
Loading