Open
Conversation
- Add sharry-logs parser for authentication failures - Add sharry-bf scenario (5 failures in 20s -> 1m ban) - Add collection, parser, and scenario documentation - Add test log samples - Detects: Authentication attempt failure for username X from ip Y
- Add sharry-logs parser tests with assertions - Add sharry-bf scenario tests with 5 authentication failures - Tests verify correct field extraction and scenario triggering
- Add timezone support to parser (UTC+11 for Sharry logs) - Add StrTimeFormat with timezone offset handling - Reduce scenario capacity from 5 to 4 (5 events need capacity 4 to overflow) - Update test assertions to expect +11:00 timezone format Fixes test failures where: 1. Timestamps weren't being parsed correctly (was defaulting to 1970) 2. Scenario wasn't triggering (needed 6 events with capacity 5, only had 5)
sabban
requested changes
Mar 16, 2026
Contributor
sabban
left a comment
sabban
left a comment
There was a problem hiding this comment.
It's great work there's only one minor requested change before merging
Thank you for your contribution
| - target: evt.StrTimeFormat | ||
| value: "2006.01.02 15:04:05:0000 -0700" | ||
| - target: evt.StrTime | ||
| expression: evt.Parsed.timestamp + " +1100" |
Contributor
There was a problem hiding this comment.
Can you replace +1100 by +0000 or Z ? It's not better because it sets the timezone to UTC, but for now it's the most common way it's done, when the log format doesn't give any information on the timezone
Replace hardcoded +1100 timezone offset with +0000 (UTC) since Sharry logs don't include timezone information. This follows the standard approach for logs without explicit timezone data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds CrowdSec support for Sharry, a self-hosted file sharing platform.
Description
Checklist