Skip to content

update default php version to 8.5#1058

Merged
henderkes merged 10 commits intomainfrom
feat/php85
Mar 11, 2026
Merged

update default php version to 8.5#1058
henderkes merged 10 commits intomainfrom
feat/php85

Conversation

@henderkes
Copy link
Collaborator

@henderkes henderkes commented Mar 11, 2026

What does this PR do?

closes #1046
closes #923

-update default to php 8.5
-fix odbc pkgconfig reporting -ltdl

@henderkes henderkes changed the title Feat/php85 update default php version to 8.5 Mar 11, 2026
@henderkes henderkes marked this pull request as ready for review March 11, 2026 02:44
@henderkes henderkes requested a review from crazywhalecc March 11, 2026 02:44
@crazywhalecc
Copy link
Owner

crazywhalecc commented Mar 11, 2026

We could update SPC to 8.5, too.

Bulk combination with PHP 8.5 seems not available yet, I'll need to fix it first.

@henderkes
Copy link
Collaborator Author

henderkes commented Mar 11, 2026

Only because of memcache (hasn't had updates in ages) and pdo_sqlsrv (which doesn't work even if it were to compile).

Edit: both were not in bulk, so it might have been swoole? I compile every other extension successfully.

@crazywhalecc
Copy link
Owner

@henderkes
Copy link
Collaborator Author

@crazywhalecc
Copy link
Owner

It appears that Swoole has added that controversial admin panel back in, causing the build to fail.

@henderkes
Copy link
Collaborator Author

henderkes commented Mar 11, 2026

I don't see anything about that. It was just that swoole < 6.2 onl worked with php 8.5.0 and under. I just tested 6.2 and it works fine. It's also been compiling fine in packages for weeks (using RC1/2).

[03:29:08] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "swoole"
[03:29:08] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n -r "assert(function_exists('swoole_cpu_num'));assert(function_exists('swoole_string'));assert(class_exists('Swoole\Coroutine'));assert(class_exists('Swoole\Coroutine\Http2\Client'));assert(class_exists('Swoole\Coroutine\WaitGroup'));assert(class_exists('Swoole\Http2\Request'));assert(constant('SWOOLE_VERSION'));"                      
[03:29:08] [I] 
[03:29:08] [I]    Build complete, used 388.354 s !
[03:29:08] [I] 
[03:29:08] [I] Static php binary path: /home/m/static-php-cli/buildroot/bin/php
[03:29:08] [I] License path: /home/m/static-php-cli/buildroot/license/

@henderkes
Copy link
Collaborator Author

Heh, now we get duplicate ftp symbols with the new version. Ugh.

@crazywhalecc
Copy link
Owner

crazywhalecc commented Mar 11, 2026

Swoole provides ftp extension features so it has confict with original ftp extension, like pdo_sqlite.

@henderkes
Copy link
Collaborator Author

Finished testing locally, ssh2 extension doesn't conflict with swoole-ssh.

@henderkes
Copy link
Collaborator Author

@crazywhalecc that did the trick, 8.5 is green now.

@henderkes henderkes merged commit 4625c6a into main Mar 11, 2026
17 checks passed
@henderkes henderkes deleted the feat/php85 branch March 11, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Swoole 6.2 Track extension progress with php 8.5

2 participants