Merged
Conversation
alfetopito
approved these changes
Feb 4, 2026
Collaborator
alfetopito
left a comment
alfetopito
left a comment
There was a problem hiding this comment.
Regarding the types, have you published the npm package yet?
I expect it to be needed for interfacing with it on bff and cowswap
Contributor
Author
No I did not, bff has the interfaces written in there, I'll make sure to revisit this though! |
Danziger
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bug I introduced after I change the code length and consolidated all regex codes to be the same.
The bug: we lowercase the code and then validate it against
/^[A-Z0-9_-]{5,20}$/which will never be true.Fix: uppercase the code before validation